search

BurntSushi / rust-cbor

CBOR (binary JSON) for Rust with automatic type based decoding and encoding.
The Unlicense
129 stars 18 forks source link

Decouple dependencies #16

Closed ghost closed 6 years ago

ghost commented 6 years ago

Hi,

May I ask if you could decouple dependencies? For a basic, simple and concise implementation, I think it would be great if there are no dependencies.

For more features, maybe you can make a separate crate...

Thank you,

BurntSushi commented 6 years ago

Sorry, but I don't understand what you're asking for. Issuing directives based on abstract principles is unlikely to get you anywhere. Instead, please describe the problem you want to solve.

With that said, I don't see myself doing anything with this crate. If you have a different vision for CBOR in Rust, then I would encourage you to build it.

On Mon, Jun 18, 2018, 00:24 hkcorac notifications@github.com wrote:

Hi,

May I ask if you could decouple dependencies? For a basic, simple and concise implementation, I think it would be great if there are no dependencies.

For more features, maybe you can make a separate crate...

Thank you,

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BurntSushi/rust-cbor/issues/16, or mute the thread https://github.com/notifications/unsubscribe-auth/AAb34udV-fOe9J-z1-h96HH5UY17DfTrks5t9ythgaJpZM4UrI0T .

ghost commented 6 years ago

@BurntSushi

Thanks, I didn't mean to be unclear. I thought an option for "no dependencies" would be a simple question... I meant it would be great if you could remake the code to not use dependencies.

However I've just read code of byteorder crate. It's huge, so I think removing dependencies wouldn't be an option.

And also you said you wouldn't code this anymore, I'm closing the issue.

Thanks again for your response.

BurntSushi commented 6 years ago

@hkcorac Thanks for clarifying. Generally, asking other people to "rebuild" entire libraries without doing any kind of research yourself about what exactly that would entail is not appreciated. Please don't do it. Instead, focus on the problem that you're trying to solve.

ghost commented 6 years ago

@BurntSushi

Thanks. I really didn't mean to ask you to do anything. That's why I used a "May I ask..." question. I did mean just to suggest a change.

From the specification here: https://tools.ietf.org/html/rfc7049, at point 1.1.2, I thought the code would be short. That was my fault. So I'm sorry.

ghost commented 6 years ago

I'm sorry I accidentally clicked "Reopen" button.