search

BurntSushi / rust-csv

A CSV parser for Rust, with Serde support.
The Unlicense
1.69k stars 219 forks source link

added NONE Terminator #332

Closed scMarkus closed 1 year ago

scMarkus commented 1 year ago

Would fix #331

This pull request would enable rust-csv to be used as a "csv line writer" with proper quoting but without appending any line terminator.

Critique on the technical level as well as the semantically one would be highly appreciated so this may become a valuable addition.

pront commented 1 year ago

Hello @BurntSushi, can we please get a review on this PR?

BurntSushi commented 1 year ago

PR review latency for me can be quite large, sorry.

The functionality being added here doesn't make sense to me. See: https://github.com/BurntSushi/rust-csv/issues/331#issuecomment-1674911636

BurntSushi commented 1 year ago

See https://github.com/BurntSushi/rust-csv/issues/331#issuecomment-1679302469