LukasKalbertodt
commented
5 years ago Appveyor fails due to errors when compiling rand_isaac:
```
Running `rustc --crate-name rand_isaac C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\rand_isaac-0.1.0\src\lib.rs --color never --crate-type lib --emit=dep-info,metadata,link -C debuginfo=2 -C metadata=d6e04fd67a256970 -C extra-filename=-d6e04fd67a256970 --out-dir C:\projects\walkdir\target\debug\deps -L dependency=C:\projects\walkdir\target\debug\deps --extern rand_core=C:\projects\walkdir\target\debug\deps\librand_core-018f0181a978bbdd.rlib --cap-lints allow`
error[E0407]: method `seed_from_u64` is not a member of trait `SeedableRng`
--> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\rand_isaac-0.1.0\src\isaac.rs:126:5
|
126 | / fn seed_from_u64(seed: u64) -> Self {
127 | | IsaacRng(BlockRng::::seed_from_u64(seed))
128 | | }
| |_____^ not a member of trait `SeedableRng`
error[E0407]: method `seed_from_u64` is not a member of trait `SeedableRng`
--> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\rand_isaac-0.1.0\src\isaac.rs:331:5
|
331 | / fn seed_from_u64(seed: u64) -> Self {
332 | | let mut key = [w(0); RAND_SIZE];
333 | | key[0] = w(seed as u32);
334 | | key[1] = w((seed >> 32) as u32);
... |
341 | | Self::init(key, 1)
342 | | }
| |_____^ not a member of trait `SeedableRng`
error[E0407]: method `seed_from_u64` is not a member of trait `SeedableRng`
--> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\rand_isaac-0.1.0\src\isaac64.rs:116:5
|
116 | / fn seed_from_u64(seed: u64) -> Self {
117 | | Isaac64Rng(BlockRng64::::seed_from_u64(seed))
118 | | }
| |_____^ not a member of trait `SeedableRng`
error[E0407]: method `seed_from_u64` is not a member of trait `SeedableRng`
--> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\rand_isaac-0.1.0\src\isaac64.rs:301:5
|
301 | / fn seed_from_u64(seed: u64) -> Self {
302 | | let mut key = [w(0); RAND_SIZE];
303 | | key[0] = w(seed);
304 | | // Initialize with only one pass.
... |
310 | | Self::init(key, 1)
311 | | }
| |_____^ not a member of trait `SeedableRng`
error[E0599]: no function or associated item named `seed_from_u64` found for type `rand_core::block::BlockRng` in the current scope
--> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\rand_isaac-0.1.0\src\isaac.rs:127:41
|
127 | IsaacRng(BlockRng::::seed_from_u64(seed))
| ^^^^^^^^^^^^^ function or associated item not found in `rand_core::block::BlockRng`
error[E0599]: no function or associated item named `seed_from_u64` found for type `isaac::IsaacRng` in the current scope
--> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\rand_isaac-0.1.0\src\isaac.rs:141:15
|
94 | pub struct IsaacRng(BlockRng);
| ----------------------------------------- function or associated item `seed_from_u64` not found for this
...
141 | Self::seed_from_u64(seed)
| ^^^^^^^^^^^^^
| |
| function or associated item not found in `isaac::IsaacRng`
| help: there is a method with a similar name: `new_from_u64`
error[E0599]: no function or associated item named `seed_from_u64` found for type `rand_core::block::BlockRng64` in the current scope
--> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\rand_isaac-0.1.0\src\isaac64.rs:117:47
|
117 | Isaac64Rng(BlockRng64::::seed_from_u64(seed))
| ^^^^^^^^^^^^^ function or associated item not found in `rand_core::block::BlockRng64`
error[E0599]: no function or associated item named `seed_from_u64` found for type `isaac64::Isaac64Rng` in the current scope
--> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\rand_isaac-0.1.0\src\isaac64.rs:131:15
|
84 | pub struct Isaac64Rng(BlockRng64);
| ----------------------------------------------- function or associated item `seed_from_u64` not found for this
...
131 | Self::seed_from_u64(seed)
| ^^^^^^^^^^^^^
| |
| function or associated item not found in `isaac64::Isaac64Rng`
| help: there is a method with a similar name: `new_from_u64`
error[E0599]: no function or associated item named `seed_from_u64` found for type `isaac64::Isaac64Core` in the current scope
--> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\rand_isaac-0.1.0\src\isaac64.rs:283:15
|
138 | pub struct Isaac64Core {
| ---------------------- function or associated item `seed_from_u64` not found for this
...
283 | Self::seed_from_u64(seed)
| ^^^^^^^^^^^^^
| |
| function or associated item not found in `isaac64::Isaac64Core`
| help: there is a method with a similar name: `new_from_u64`
error: aborting due to 9 previous errors
```
Notably: AppVeyor tries to compile rand_isaac 0.1.0 while Travis compiles 0.1.1 which got some version requirement fixes. Not sure what exactly is happening here tho. But I'm pretty sure this has nothing to do with this PR.
BurntSushi
jonasbb
Fixes #118
As discussed in the issue, the fix is fairly straight forward. I even managed to create a fairly minimal example in form of a test. It indeed panics before the patch and works fine afterwards. I used
self.pop()inskip_current_diras I think it's correct there. As far as I can tellstack_pathhas always the same length asstack_listor is empty. So there is no reason to treat them independently.Regarding the second way the invariant can be destroyed I mentioned here: I tried to trigger this bug, but it's hard. So I think this can only go wrong when
Ancestor::newreturns an error. This apparently only happens on Windows (which I'm not currently using) and I don't know when exactly this error is triggered. So I will stop now in trying to trigger the bug. So the question is: should I "fix" this what I think is a bug in some situations OR should I just keep it as is?