BurntSushi / walkdir

Rust library for walking directories recursively.
The Unlicense
1.21k stars 106 forks source link

pop path on error #129

Closed forensicmatt closed 4 years ago

forensicmatt commented 4 years ago

It appears that because the current path is not getting popped on an error, this can result in trying to open the same path when there is an error leading to a infinite loop in certain occasions. This issue was observed here: https://github.com/BurntSushi/walkdir/issues/128

forensicmatt commented 4 years ago

I am going to close this. I am not sure this is where this needs to be addressed. The standard library also get stuck in an infinite loop on the error that this fix resolves, which makes me think that this might be a fs::read_dir issue. I am going to further explore on https://github.com/BurntSushi/walkdir/issues/128.