search

BurntSushi / walkdir

Rust library for walking directories recursively.
The Unlicense
1.24k stars 107 forks source link

Added contents_first option #19

Closed mcharsley closed 7 years ago

mcharsley commented 7 years ago

18

Added ability to yield the contents of the directory before the directory itself

BurntSushi commented 7 years ago

Thanks for doing this! I've only glanced at it, but it seems reasonable. I will need to do a more thorough review before merging though.

From skimming, I see that the code style is pretty inconsistent. Can you please write code in a style that is consistent with the rest of the code in this repo? As it stands now, I see a lot of indentation inconsistencies. Please also adhere to a 79 column limit (inclusive).

mcharsley commented 7 years ago

Sure will do. Just realised that I forgot to get approval from our open source folks (should just a formality) so please don't submit yet...

On 2 Feb 2017 5:19 pm, "Andrew Gallant" notifications@github.com wrote:

Thanks for doing this! I've only glanced at it, but it seems reasonable. I will need to do a more thorough review before merging though.

From skimming, I see that the code style is pretty inconsistent. Can you please write code in a style that is consistent with the rest of the code in this repo? As it stands now, I see a lot of indentation inconsistencies. Please also adhere to a 79 column limit (inclusive).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BurntSushi/walkdir/pull/19#issuecomment-277021661, or mute the thread https://github.com/notifications/unsubscribe-auth/ALbIF_p8vwi6HGLuSOuaqqcXSgYIUv6iks5rYhABgaJpZM4L1WtK .

mcharsley commented 7 years ago

Right I think I've updated the pull request with a format change commit. Apologies for that - hadn't realised that my eclipse setup was set to use tabs under some circumstances.

Also have permission to submit the code now, the powers that be have checked that I'm not giving away confidential google code :-)

michaelsproul commented 7 years ago

Go for it @mcharsley. I ended up not needing a post-order option in my project, so my branch is neglected...

mcharsley commented 7 years ago

@BurntSushi : friendly ping now Michael's bowed out...

BurntSushi commented 7 years ago

@mcharsley All set! Sorry for the delay. Thanks so much!

mcharsley commented 7 years ago

Excellent, thanks very much.

Have you got an ETA for a release to crates.io with this in?

In the meantime I'll change my cargo file to point to the official github project rather than my fork :-)

Mark

On Tue, May 9, 2017 at 12:04 AM, Andrew Gallant notifications@github.com wrote:

@mcharsley https://github.com/mcharsley All set! Sorry for the delay. Thanks so much!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BurntSushi/walkdir/pull/19#issuecomment-300015113, or mute the thread https://github.com/notifications/unsubscribe-auth/ALbIF619vC3CPD1MXOcPrRXMQnTti8shks5r359qgaJpZM4L1WtK .