search

BurntSushi / walkdir

Rust library for walking directories recursively.
The Unlicense
1.24k stars 107 forks source link

Should `impl From<walkdir::Error> for std::io::Error` #4

Closed pnkfelix closed 8 years ago

pnkfelix commented 8 years ago

Right now, code that uses walkdir cannot just do try! within a function that returns Result<_, io::Error>

It would be more convenient if it implemented the corresponding conversion via the From trait: https://doc.rust-lang.org/std/convert/trait.From.html

pnkfelix commented 8 years ago

Wait a minute, the documentation say that you do have such an impl... what the heck...

pnkfelix commented 8 years ago

(sorry, this was my own mistake; the crate I'm mucking with has its own local wrapper around io::Error and so I need to add a From impl for that wrapper...)

BurntSushi commented 8 years ago

I love it when issues fix themselves. :-) Cheers!