Use `?` in docs instead of unwrapping

BurntSushi / walkdir

Rust library for walking directories recursively.

The Unlicense

1.22k stars 107 forks source link

Closed msehnout closed 7 years ago

msehnout commented 7 years ago

Fixes: #25 except for "examples on WalkDirIterator.skip_current_dir" because there is no unwrap()

msehnout commented 7 years ago

@budziq I've submitted a new version of this PR with fixed issues and reverted travis.yml.

budziq commented 7 years ago

@msehnout reverting the travis.yml might be a little bit to early as now the travis build for backwards compatibility (rust 1.10.0) fails.

Please note that the ? operator was stabilized later in rust 1.13 so any builds with ? will always fail unless:

@burntsushi decides to move minimal backwards compatible version to 1.13 and you update the travis.yml
you change ? to try!

I would suggest option 1. but it is not my place to decide :smile_cat:

I would suggest updating the PR to make it pass travis test. Chose one of the two options and wait for maintainers approval or suggestions.

msehnout commented 7 years ago

@budziq I think I'll just wait for @BurntSushi's opinion.

BurntSushi commented 7 years ago

Since we're releasing a 2.0, I think we should bump the minimum Rust version as well! I think we should move to Rust 1.16, which is $CURRENT - 2.

msehnout commented 7 years ago

Sounds good to me. Once the version in travis is changed, I can rebase this patch to run CI again.

msehnout commented 7 years ago

Or should I bump it?

budziq commented 7 years ago

@msehnout version bum is already waiting for merge https://github.com/BurntSushi/walkdir/pull/62

BurntSushi commented 7 years ago

Thanks! I think this is ready to go but needs a rebase first.

msehnout commented 7 years ago

Ok, I have the fix, but I cannot authenticate against Github. Seems to be broken using either https or ssh. I'll submit the patch later.

msehnout commented 7 years ago

It should be ready.

BurntSushi commented 7 years ago

Awesome, thank you!