Remove re-export of is_same_file

BurntSushi / walkdir

Rust library for walking directories recursively.

The Unlicense

1.22k stars 107 forks source link

Remove re-export of is_same_file #56

Closed jeremielate closed 7 years ago

jeremielate commented 7 years ago

Added a wrapper around this function that is deprecated. Fixes #43.

BurntSushi commented 7 years ago

Since we're releasing a 2.0, I think we should just remove this API instead of deprecating it. Two reasons. Firstly, this is pretty niche and I doubt many are using it. Secondly, switching over to the same-file crate should be a trivial fix.

brson commented 7 years ago

sgtm @jeremielate can you update the pr to remove the deprecated function?

brson commented 7 years ago

This is ready for another look @BurntSushi

BurntSushi commented 7 years ago

Thanks @jeremielate!