search

BurntSushi / wingo

A fully-featured window manager written in Go.
Do What The F*ck You Want To Public License
1k stars 86 forks source link

ToggleMaximize can not restore its original position #112

Open dlintw opened 10 years ago

dlintw commented 10 years ago

Test method: (I've changed all Mod1 key as Mod4 key) Mod4-t launch terminal ( assume put on x1,y1-x2,y2 rectangle) Mod4-x maximize it Mod4-x un-maximize it (but it restored to another position and size different to x1,y1-x2,y2)

BurntSushi commented 10 years ago

I can't reproduce this. Can you give more details? Does it happen for every window? If not, which one does it happen for? Can you get precise measurements on how the geometry differs? (Try using xwininfo.)

dlintw commented 10 years ago

I press about 10 times of Mod4-x, and then it occurs. x y w h comment 379 412 722 434 first time launch lilyterm named as T1 0 31 1280 956 press mod4-x 1st 379 412 722 434 press mod4-x 2nd and press more than 10 times, it works OK.

I try create another terminal by Mod4-t again named as T2 434 193 818 477 # original 0 31 1270 952 # mod4-x 1st, it is strange now, differ then previous T1 maximum size 434 193 818 477 # mod4-x 2nd, restored OK 0 31 1270 952 # mod4-x 3rd, maximum OK 434 193 1268 933 # mod4-x 4th, restored to wrong position 0 31 1278 952 # mod4-x 5th, seems larger on maximum 434 193 1268 933 # mod4-x 6th, restored to wrong position too

BurntSushi commented 10 years ago

Hmm. I was able to reproduce this with lilyterm by opening one terminal and repeatedly pressing Meta-x. The window is restored to its correct size and then it jumps to a size resembling its maximized state but without changing its x and y coordinates.

I'll have to debug this further, but I suspect lilyterm may be at fault here. I can't reproduce it with any other client.

dlintw commented 10 years ago

BTW, is there useful hint to test this issue, could I change wingo hot key behavior through wingo-cmd ?

BurntSushi commented 10 years ago

I don't really understand your question. Change what behavior? You can change (just about) every key binding in Wingo, including maximize/unmaximize toggling.

The actual stuff that happens when you maximize or unmaximize cannot be changed. Wingo follows the EWMH standards. Clients should too.

dlintw commented 10 years ago

I changed the key binding to lxterminal and it occurs the same problem. When I try use xterm it won't.

In the previous BTW question, I mean could I change key binding on runtime without modify the key.wini and kill wingo process and restart wingo.

BurntSushi commented 10 years ago

I can reproduce it with lxterminal too. Interestingly, they are both built with vte, so I wonder if that's the culprit. Either way, I need to dig further before I'll know for sure.

In the previous BTW question, I mean could I change key binding on runtime without modify the key.wini and kill wingo process and restart wingo.

There's no need for this. Bind a key to an arbitrary bash script, then change what that script does at your discretion.

The only way to reload changes in config files is to restart Wingo.