search

BurntSushi / wingo

A fully-featured window manager written in Go.
Do What The F*ck You Want To Public License
1k stars 90 forks source link

Urgency event Skype #17

Closed alxzh closed 12 years ago

alxzh commented 12 years ago

Hi,

When skype informs about urgency even border a round window starts pulsing. But in tail mode if I switch from other virtual desktop and skype gets focus border still pulse even if I click in its window. Same thing happens when I have a conversation with one person and somebody other writes to me border starts pulsing and remain in such state even after selecting char with this person. Pulsing finishes only if I change focus to some other window on same virtual desktop and then switch back. Oh, forgot to mention, I see such effect with tailing mode.

Regards, Alex

BurntSushi commented 12 years ago

I've committed a possible fix, although I wasn't able to reproduce the bug.

I had a little trouble understanding your report, so I'd like to write what I believe the problem is. If I've misunderstood you, could you clarify for me?

If that was the problem, then the commit should fix that.

Also, whether you're tiling or not shouldn't have any effect.

alxzh commented 12 years ago

Yes, this exactly was the problem. I'll test the fix today. Thanks On Oct 26, 2012 8:08 AM, "Andrew Gallant" notifications@github.com wrote:

I've committed a possible fix, although I wasn't able to reproduce the bug.

I had a little trouble understanding your report, so I'd like to write what I believe the problem is. If I've misunderstood you, could you clarify for me?

  • Skype windows flash at the proper time when you receive an IM.
  • If you already had focus on the window, clicking on it doesn't stop it.
  • But if you focus another window and then re-focus the flashing window, the flashing stops.

If that was the problem, then the commit should fix that.

Also, whether you're tiling or not shouldn't have any effect.

— Reply to this email directly or view it on GitHubhttps://github.com/BurntSushi/wingo/issues/17#issuecomment-9802977.

alxzh commented 12 years ago

Now it stops flashing but orange border around window also disappears. So it isn't clear now which window is active. But you are on correct track :)

BurntSushi commented 12 years ago

All right, hopefully I've got it right now :-)

alxzh commented 12 years ago

Any new on this one? I understand that fix should be pretty simple. I'd try to fix it myself but have no time.

BurntSushi commented 12 years ago

The comment right before yours says it should be fixed. Have you updated? And is the behavior still the same?

alxzh commented 12 years ago

Ah, my bad, haven't seen this commit. Recompiling...

alxzh commented 12 years ago

Hooray!!! It's fixed, thanks a lot.