search

BurnySc2 / python-sc2

A StarCraft II bot api client library for Python 3
MIT License
485 stars 155 forks source link

ability_id is not up to date for 5.0.6 #92

Closed etzhang416 closed 2 years ago

etzhang416 commented 3 years ago

For now, in SC2 AI Arena the maps are in version 5.0.6. But the ability-id is currently 5.0.3. It would be nice to have 5.0.6 ability ids because Protoss macro builds heavily relies on shield battery and AbilityId.BATTERYOVERCHARGE_BATTERYOVERCHARGE is no longer working.

Thanks for all the way along!

RZarifov commented 3 years ago

When did 5.0.6 release? I see no information on the website.

RZarifov commented 3 years ago

Went to see for myself and indeed 5.0.6 did release. Yet no patchnotes and no news about it. This is laughable.

BurnySc2 commented 3 years ago

As far as I know, the SC2 AI Arena maps run with Scarlett's 5.0.6 maps. The stableid.json for those maps can be found here: https://github.com/shostyn/sc2patch/tree/master/Patch/5.0.3.81433/Base.SC2Data/GameData

Perhaps you could regenerate the IDs with it? The regeneration script is here (which loads the data from the stableid.json file): https://github.com/BurnySc2/python-sc2/blob/develop/generate_id_constants_from_stableid.py

Also check out the version manager from sharpy, which changes enum values around: https://github.com/DrInfy/sharpy-sc2/blob/653dec3fd0823da99c4517924f425c0c0fe27039/sharpy/managers/core/version_manager.py#L20

BurnySc2 commented 3 years ago

I added IDs from the stableid.json from the first link. The ID changes are currently the following: https://github.com/BurnySc2/python-sc2/commit/4b7eb747908e1d57a18cfc7ea540b11c2f9969dd

These ID changes are in a seperate branch: https://github.com/BurnySc2/python-sc2/tree/linux-5.0.6

With that, I think im able to close this issue.

BurnySc2 commented 2 years ago

Please reopen if you think the issue still exists.