search

BurnySc2 / sc2-planner

MIT License
48 stars 13 forks source link

combat shields (ShieldWall) time off #18

Closed jtsauls closed 3 years ago

jtsauls commented 3 years ago

True research time is 79s but comes up on the planner as almost 2minutes.

BurnySc2 commented 3 years ago

Can you give me an example build order (with link) where this is incorrect? It looks correct to me: Build order combatshield

jtsauls commented 3 years ago

Apologies for the hasty issue. Upon further investigation the issue is that combat shields can begin before stim is finished. But it still requires 79seconds after stim is finish to be completed, leading to a longer than normal research time. Same effect for concussive shells.

See this BO.

This also lead to strange behavior where you can change the order of the upgrades in the bar at the top in a way that should not be allowed.

jtsauls commented 3 years ago

TechLab upgrades on Factory and TechLab on Starport have this bug as well. But not the other upgrades on the Engineering bay, Armory, Ghost Academy or Fusion core.

BurnySc2 commented 3 years ago

I've found another bug where unit training would block the addon from researching: Screenshot_2021-01-22_08-57-16

But this is now also resolved: Screenshot_2021-01-22_08-57-41

Internally it was queueing the upgrade without checking if the addon was still busy.

Thanks for the find!

Edit: I've seen that you tried to research something multiple times, which I suppose is indeed a bug. I created a new issue: https://github.com/BurnySc2/sc2-planner/issues/22