BurnySc2 / sc2-planner

MIT License
50 stars 13 forks source link

building specific chronoboosts #27

Closed jtsauls closed 3 years ago

jtsauls commented 3 years ago

Adds unique chronoboost icons for protoss buildings and appropriate path references.

Building image at 75% size was overlayed on chronoboost icon in bottom left corner at 90% opacity.

pikiou commented 3 years ago

It looks really cool!

BurnySc2 commented 3 years ago

Thank you. It looks great.

Did you edit the images yourself, or where did you get them from? I'm asking because of the MIT license and copyright.

jtsauls commented 3 years ago

I edited them myself. I was thinking that might be a little weird with the copyright. Fair use perhaps?

BurnySc2 commented 3 years ago

I've honestly no clue how it works.

I think if you add them via MIT license and you own the pictures, that you give up the rights to MIT license.

Edit: Perhaps another entry in the https://github.com/BurnySc2/sc2-planner#copyright section is required if you intend a different license for your images?

jtsauls commented 3 years ago

I don't think I can own those images, as they are just a combination of the icons in the repo that were owned by Blizzard. I renounce any ownership I would have, for what it's worth.

I feel we're in the clear here most likely (no more egregious that using the blizzard's icons as already done).

BurnySc2 commented 3 years ago

Oh yes, I forgot that they are originally owned by Blizzard.

The way you suggested sounds like the easiest solution. Thanks again!