search

BurnySc2 / sc2-planner

MIT License
48 stars 13 forks source link

Update workflow, add pre-commit-hook, add end-to-end tests, add eslint, update data.json, update packages #32

Closed BurnySc2 closed 2 years ago

jtsauls commented 2 years ago

@BurnySc2 This merge breaks my old build order links.

Conversely, build orders that I make on this merge #32 don't work on a local dev version of merge #31. I get "Error: incorrect header check"

Weirdly, the example BOs on the repository site do work on my local version of merge #31, but they break if I edit them on your host and then try to transfer them to my local version. In that case I get the incorrect header check error.

Any thoughts? How should I migrate my old links?

Here's a BO link from merge #31 where two SCVs are being built that breaks in the new pull: 2 SCV BO

jtsauls commented 2 years ago

This is resolved with the pako revert.

BurnySc2 commented 2 years ago

@jtsauls whoops, I've just seen these comments. I'm glad they got fixed too! I'm slowly implementing end-to-end tests so this shouldn't happen again.