search

BurnySc2 / sc2-planner

MIT License
48 stars 13 forks source link

Update live version with current SC2 game state #37

Closed Alexei-Kornienko closed 2 years ago

Alexei-Kornienko commented 2 years ago

Seems that live version is using slightly outdated buildings cost and timings. They need to be updated to current version

Hatchery for example is 300 minerals Pool is 200 minerals Rouch Warren - 150 minerals Banneling nest - 100 minerals 50 gas Extractor - 25 minerals

BurnySc2 commented 2 years ago

Can you be more specific? Which buildings exactly? And what timings are off?

BurnySc2 commented 2 years ago

You are welcome to edit your posts instead of making multiple.

Yea, it seems all Zerg structures are affected, aswell as structures regarding morphs (Lair, OrbitalCommand, Ravager).

Alexei-Kornienko commented 2 years ago

Sure.. I can even try to file a pull request with a fix :)

BurnySc2 commented 2 years ago

A PR is welcome, as long as you don't hardcode the costs. I'm 99% sure the costs were correct at one point, but some change added this bug.

Alexei-Kornienko commented 2 years ago

Not sure what you mean don't hardcode the costs. Aren't they hardcoded here? https://github.com/BurnySc2/sc2-planner/blob/77090fbc18acca6b8a53adba77a3f065673e07ec/src/constants/data.json#L11020

BurnySc2 commented 2 years ago

Yes, but that file was auto-generated by https://github.com/BurnySc2/sc2-techtree Those resources basically mean what the true "value" of the unit is - in the case of a hatchery it is the price of the drone plus the build cost.

Alexei-Kornienko commented 2 years ago

Ah I see... so it may not be the issue in such case

Alexei-Kornienko commented 2 years ago

Many thanks for quick reply in any case

BurnySc2 commented 2 years ago

Well don't close the issue ;D The issue should only be closed once this has been fixed. Thanks for reporting it!