search

BurtDS / laravel-vatnumber-checker

A small laravel package that allows you to easily retrieve information associated with a VAT number.
MIT License
46 stars 5 forks source link

Can we release existing changes? #5

Open alies-dev opened 3 hours ago

alies-dev commented 3 hours ago

On my project I have pretty advanced CI/CD scripts with static analysis and composer validate --no-check-all --strict command.

To pass static analyses, I created https://github.com/BurtDS/laravel-vatnumber-checker/pull/4

Now, I use commit-ref in our composer.json to that commit/fix in order to make SA, but composer validate treats it as a security issue:

composer validate --no-check-all --strict
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
# General warnings
- The package "burtds/laravel-vatnumber-checker" is pointing to a commit-ref, this is bad practice and can cause unforeseen issues.

Can we please release existing changes as a new patch release?

BurtDS commented 2 hours ago

Hi Alies,

I forgot to release the changes. I've created a new release. So normally this should be fine now. Can you confirm?