search

BusKill / usb-a-magnetic-breakaway

Design requirements for an open-source USB-A magnetic breakaway connector used in the BusKill laptop kill cord
GNU General Public License v3.0
35 stars 2 forks source link

Updated Readme and small change to part #8

Closed goldfishlaser closed 1 month ago

goldfishlaser commented 1 month ago

Just added what's new and made a minor change to the part.

maltfield commented 1 month ago

Thanks for the PR :) The changes to the README.md and .scad file look fine, but I don't know how to check the .stl file.

Do you have any advice on how I can diff the .stl file and scan/sanitize it for any potentially-malicious changes? Is there something like qvm-convert or Dangerzone for .stl files?

goldfishlaser commented 1 month ago

Have no idea. But it seemed to provide a diff when I submitted it.

On Wed, Jul 24, 2024, 3:53 PM Michael Altfield @.***> wrote:

Thanks for the PR :) The changes to the README.md and .scad file look fine, but I don't know how to check the .stl file.

Do you have any advice on how I can diff the .stl file and scan/sanitize it for any potentially-malicious changes? Is there something like qvm-convert https://blog.invisiblethings.org/2013/02/21/converting-untrusted-pdfs-into-trusted.html or Dangerzone https://dangerzone.rocks/ for .stl files?

— Reply to this email directly, view it on GitHub https://github.com/BusKill/usb-a-magnetic-breakaway/pull/8#issuecomment-2248787688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAER7EAR6TZ7Y7ZGQU3KJE3ZOAA4LAVCNFSM6AAAAABLNASFMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYG44DONRYHA . You are receiving this because you authored the thread.Message ID: @.***>

goldfishlaser commented 1 month ago

Oh sorry, right, the stl not the scad. Yeah, no idea.

On Wed, Jul 24, 2024, 4:06 PM Melanie Allen @.***> wrote:

Have no idea. But it seemed to provide a diff when I submitted it.

On Wed, Jul 24, 2024, 3:53 PM Michael Altfield @.***> wrote:

Thanks for the PR :) The changes to the README.md and .scad file look fine, but I don't know how to check the .stl file.

Do you have any advice on how I can diff the .stl file and scan/sanitize it for any potentially-malicious changes? Is there something like qvm-convert https://blog.invisiblethings.org/2013/02/21/converting-untrusted-pdfs-into-trusted.html or Dangerzone https://dangerzone.rocks/ for .stl files?

— Reply to this email directly, view it on GitHub https://github.com/BusKill/usb-a-magnetic-breakaway/pull/8#issuecomment-2248787688, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAER7EAR6TZ7Y7ZGQU3KJE3ZOAA4LAVCNFSM6AAAAABLNASFMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYG44DONRYHA . You are receiving this because you authored the thread.Message ID: @.***>

maltfield commented 1 month ago

The GitHub WUI says the .stl file's diffs are:

39,614 additions, 39,726 deletions not shown because the diff is too large

I think we need to figure out a safe way to diff this before I can merge it. The .stl file is generated from the .scad file, right? If so, I guess it's redundant and we can omit it? I'll merge this if you exclude the .stl file. Otherwise we'll need to figure out some way to scan/sanitize it.