BusPirate / Bus_Pirate

Community driven firmware and hardware for Bus Pirate version 3 and 4
625 stars 130 forks source link

Mismatch in measure unit and wrong value into messages v3.s #114

Open USBEprom opened 5 years ago

USBEprom commented 5 years ago

After the changes in the code provided by Christopher Sam Soon (many thanks), aware of the limits he has explained the message ~400kHz it can not exists anymore for I2C SOFTWARE, 2-WIRE and 3-WIRE, because of the speed limit of ~240kHz, even if in reality above all the 3-WIRE protocol has even more stringent limits. At this point perhaps it would be appropriate to modify this message by changing it from ~400kHz to ~240kHz precisely. But perhaps this could lead to incompatibility with the old documentation and tutorials, I would not know. Anyway, I noticed that messages_v3.s contains a wrong wording as the unit of measurement for the frequency used is written KHz which actually does not exist being the correct word kHz. For this reason I think it will be necessary to decide what to do. The latest firmwares that I put on the forum of dangerousprototypes (http://dangerousprototypes.com/forum/viewtopic.php?f=28&t=8498&start=120#p67834) use both the correct wording kHz that the value ~240kHz (actually ~220kHz, but for now you can pass it on). Attached the updated messages_v3.s file as I modified it to build my own custom firmware. I am talking about the Bus Pirate v3 because I have that, the speech could also apply to the Pirate Bus v4 though, of course.

NEW_messages_v3.zip