Closed smadoori closed 9 years ago
Hey @smadoori thanks for pointing this out - taking a look now (sorry about the slow reply - was away on Holiday).
First - I've pushed a change that takes care of the embed.php
bug - thanks for catching that.
Second and more importantly - not seeing that rogue checkbox. Salsa's ever changing API sometimes returns weird fields that should be ignored but slip through my filters. It also may be a group or tag.
Could you visit this API call and tell me what you see (you'll need to be logged into Salsa). It'll help me debug what's causing the checkbox. I also don't currently see the checkbox so maybe things are working better?
I'm in the final stages of getting a website to go live on Monday, and we had the same thing happen. What it turns out to be is the REQUIRED CONFIRMATION TEXT field on Sign-Up forms. Even if you leave that field blank you get the required checkbox. If you put something into the required text box then you'll see that it lines up with that box.
The solution we've decided on is to make all our input forms Petitions, instead of Sign-Up forms. The Sign-Up form does not get the erroneous Required Text box to appear.
![Uploading Screen Shot 2014-02-22 at 2.37.14 PM.png . . .]()
@imaginautdesigns I can help debug this if you can post a link to that page and paste the results of this api call:
http://wfc2.wiredforchange.com/api/getObject.sjs?object=signup_page&key=your-form-id&json
where you've replaced your-form-id
with the form in question.
Salsa occasionally returns a weird field - but as I don't see the API results I can't debug and filter this in the future
At the moment we are not using any of the "Sign Up" Forms in Salsa to avoid the checkbox issues, so it's not an issue right now. However in the interest of solving future issues, I've set-up a test/debugging page with one of our Sign-Up forms embedded via the SalsaPress plug-in. Not sure I have it set up right. This look okay? ![Uploading Screen Shot 2014-02-23 at 3.03.28 PM.png . . .]()
@imaginautdesigns your uploads aren't working - please just paste the text
I'm far more interested resolving the Zip/Postal Code issue from my other post. We cannot get the Zip/Postal Code field to be required even though in our Salsa account it is check as required. It also does not appear with an asterisk showing it is required.
This is just a test page to help the SalsaPress plug-in developer with debugging the API of the Sign-Up Forms.
http://wfc2.wiredforchange.com/api/getObject.sjs?object=signup_page&key=9016;json
[salsa data=' {"name":"type","value":"signup_page"},{"name":"salsa_key","value":"9016"},{"name":"salsa_title","value":"on"},{"name":"salsa_description","value":"on"},{"name":"after-save","value":""} ']
visit this page and paste what you see into github
[{"result":"error","messages":["There was a problem with your submission. Please authenticate in order to continue."]}]
That must not be your base URL of salsa - try it again by visiting
where-ever-you-log-into-salsa.com /api/getObject.sjs?object=signup_page&key=9016&json
I've gone to the Salsa Page for the form. Not using the plug-in here, I assume this page will help?
http://salsa3.salsalabs.com/o/51084/c/10476/p/salsa/web/common/public/signup?signup_page_KEY=9002
Different key - different form. But this one has does not have the "phantom checkbox" or the Zip Code required / not working issue. That only happens with the plug-in on the WordPress page. Just making sure. ;-)
Thank you for your time looking into this.
So - just to clarify - when you use SalsaPress and Salsa Form #9002 - everything works fine?
But if you use SalsaPress and a different form - you get the zip issue you mention in #26 and the checkbox mentioned here?
When I use the SalsaPress Plug-in with any Sign-Up form the Required Confirmation Text becomes a checkbox on that Sign-Up form. When embedded in WordPress via SalsaPress. (even though that box has no text nor spaces in it -- checked that several times. ;-) )
When using SalsaPress Plug-in on any form Sign-up / Petition / Event -- the Zip Code field does not show a required asterisk nor is it required to submit the form. Even though in our Salsa account we've check it as required. All other fields are fine, but not the Zip/Postal Code
We too are having this issue
http://www.evangelicalsforsocialaction.org/action-center/
Please advise?
Alright in the case of @arlyt there's two issues:
Email_Confirmed_Opt_In
button. There's an Opt_in_Text
field... but I can't find a way in Salsa to set it (typical)Have pushed a fix to both of these so maybe all better now. I'll update the WordPress plugin shortly - get your fix from GitHub in the meantime.
I think I fixed this, yes? no? maybe?
This was over a year ago …… I think so?
It was on a client’s site and they’ve changed the way they were using the forms …. so I think it all worked out. shrug :-D
Chris Stuart | Imaginaut Designs | 417-224-7491 | imaginautdesigns.com
On Apr 23, 2015, at 8:23 AM, Scott Duncombe notifications@github.com wrote:
I think I fixed this, yes? no? maybe?
— Reply to this email directly or view it on GitHub.
I'm going to call it a win
Scott – yep, the fix worked awhile ago and we were able to address the aberrant check box that was appearing in our embedded forms – thanks so much!
-Suraj
From: Scott Duncombe notifications@github.com<mailto:notifications@github.com> Reply-To: BusProject/SalsaPress reply@reply.github.com<mailto:reply@reply.github.com> Date: Thursday, April 23, 2015 at 3:22 PM To: BusProject/SalsaPress SalsaPress@noreply.github.com<mailto:SalsaPress@noreply.github.com> Cc: Surajkumar Madoori smadoori@aidschicago.org<mailto:smadoori@aidschicago.org> Subject: [BULK] Re: [SalsaPress] Pesky Checkbox Appearing on Salsa forms (#24)
I'm going to call it a win
— Reply to this email directly or view it on GitHubhttps://github.com/BusProject/SalsaPress/issues/24#issuecomment-95709073.
Hello - I have a problem that I hope I can get help to address.
We are building a new website on Wordpress and one of our goal is to integrate Salsa throughout to better get individuals involved in our organization using the SalsaPress plugin. We've noticed a strange error that's happening with our forms (see screenshot), on the homepage, bottom left corner we have a Salsa form for sign-up. We've had this random 'required' checkbox appear out of nowhere, when our forms don't have them in Salsa.
We also noticed this error that appearing near the Salsapress icon in blog posts during drafting mode right above the WYSWYG: Warning: _() expects exactly 1 parameter, 2 given in /home/bgriffith/hivpja/src/wp-content/plugins/salsa-press/admin/embed.php on line 7
I also attached a screenshot to illustrate an example of what we are seeing on website.
We wondering anyone had any insight or possibly help us resolve this problem? We are trying to launch this site soon and really need to resolve this ASAP. Any help is greatly appreciated.