BusProject / SalsaPress

SalsaPress connects WordPress to Salsa. Developed by the Bus Federation and Bus Project.
http://wordpress.org/extend/plugins/salsa-press/
8 stars 2 forks source link

editor_plugin.js problem with latest wordpress version #30

Closed alison985 closed 10 years ago

alison985 commented 10 years ago

Hi,

This piece of JS in editor_plugin.js causes a browser console error and prevents the tinymce WYSIWYG bar from showing up when editting posts:

 tinymce.dom.Event.add(dellButton, 'mousedown', function(e) {
            var ed = tinyMCE.activeEditor, el = ed.selection.getNode();

            if ( el.nodeName == 'IMG' && ed.dom.hasClass(el, 'salsa') ) {
                ed.dom.remove(el);

                ed.execCommand('mceRepaint');
                return false;
            }
        });

Right now I fixed it by commenting the above lines out, but I would like a fix that doesn't remove functionality. Any advise is appreciated.

Alison

mojowen commented 10 years ago

Yeah looks like the TinyMCE api has changed since I wrote this. Will fix soon

drywall commented 10 years ago

WordPress 3.9 moved to 4.x of TinyMCE, which I believe has very different API than 3.x…

Yeah looks like the TinyMCE api has changed since I wrote this. Will fix soon

— Reply to this email directly or view it on GitHub.

mojowen commented 10 years ago

Ok - pushing fix to Github and WordPress now