Preliminary cleanup - Githubissues

BusProject / SalsaPress

SalsaPress connects WordPress to Salsa. Developed by the Bus Federation and Bus Project.

http://wordpress.org/extend/plugins/salsa-press/

8 stars 2 forks source link

Preliminary cleanup #34

Closed drywall closed 10 years ago

drywall commented 10 years ago

Putting constants in uppercase per normal PHP code style.

Also upgrading menu icon and TinyMCE button appearance to be more consistent with WP >= 3.8, right now things look a little funky.

No functional differences and minimal UX work, really.

mojowen commented 10 years ago

Looking good to me - from the code review it looks like you mostly:

Swapped in the capitalized SALSAPRESS_BASE
Added some classes
Replaced the logo

Anything else I'm missing?

drywall commented 10 years ago

Sorry for the delay in getting back to you, I was out of the country for a bit.

Capitalized all the constants I spotted and made several admin-facing CSS changes (which entailed adding some classes I think) to make the editor button look better (at least, it looks better in WP >=3.9, not sure if I made it uglier in older versions of WP).

I may have more bandwidth to work on this significantly later this month.

mojowen commented 10 years ago

LGTM - :ship: ing