search

BusTicker / BusTicker-Server

MIT License
0 stars 0 forks source link

Implement bounding box check for a coordinate #13

Open brennanMKE opened 10 years ago

brennanMKE commented 10 years ago

See the isInBoundingBox function in bustime.js for what needs to be implemented. The bounding box is created in the function just above it. Once they are done both will need to be tested. I wrote some code in JavaScript a while back which worked with Google Maps for bounding box but that code may not be on GitHub. I have to look for it.

Using the bounding box will cut down on using the haversine function which can be a bit processor intensive when there are more coordinates to process, especially for a city like Chicago. It appears to run very quickly for Milwaukee.

https://github.com/BusTicker/BusTickr-Server/pull/12/files#diff-ee81bfd40e82aba1581a82ad8aa983caR230

@tdhsmith

brennanMKE commented 10 years ago

From @morganherlocker on Twitter:

@brennanMKE fastest would be an inline check if(lon>=bbox[0]&&lon<=bbox[2]&&lat>=bbox[1]&&lat<=bbox[3]){console.log('inside')}

https://twitter.com/morganherlocker/status/526477105832677377

brennanMKE commented 10 years ago

From @morganherlocker on Twitter:

@brennanMKE for greater precision, use turf-inside, which is fast, and checks if a pt falls on any type of geometry https://t.co/MHf5kOu8ZD

https://twitter.com/morganherlocker/status/526477521781792768