search

BustByte / coronastatus

Anonymous crowd sourcing of COVID-19 symptoms all over the world (with public data sets)!
MIT License
173 stars 89 forks source link

Move country or domain specific domains out of locales #509

Closed jinjie closed 4 years ago

jinjie commented 4 years ago

I propose that we move the country names, health agency name, domain names out of the translation file.

Since there is multiple language per country, there will come a case where, a country do not have it's own english locale. For example, there is no locale code of "en-MY". We may think that it is English (Malaysia) but based on the list of locales, there is no such locale at all: https://github.com/mozilla/language-mapping-list/blob/master/language-mapping-list.js

Since it is still english, we may choose to include en-US for Malaysia. When we do that, we will see something like:

Fill out this form - it takes 1 minute - and help the United States gain control over COVID-19.

Which is wrong.

I feel there is advantages by improving how we improve the locales. Such as the possibility of switching to an available locale as detected on the browser.

fossecode commented 4 years ago

Ahh good point, didn't think about that.

jinjie commented 4 years ago

Is it difficult to achieve this? We can still manage with the current locale setup, but it may become a mess when more countries and locales join in.

We will also see a lot of duplicated locale files. For example, I am using en-SG for English (Singapore). In fact, I can easily use en-UK for Singapore.

fossecode commented 4 years ago

Fixed in #537