BusterLabs / Partyshare

A free, open source file sharing application, built on the peer-to-peer hypermedia protocol IPFS.
https://busterlabs.github.io/Partyshare
MIT License
158 stars 26 forks source link

Auto-update files not generated for linux build #53

Closed bhstahl closed 6 years ago

bhstahl commented 6 years ago

Building off of #47, linux builds are not generating the latest-linux.{json,yml} files

cc @hexagon6

hexagon6 commented 6 years ago

@bhstahl nice! Unfortunately I don't see drafts. How can I test it beforehand? Upload it to ipfs? ;-)

bhstahl commented 6 years ago

Ah, right. Here it is https://gateway.ipfs.io/ipfs/QmZN3S1X8vSTbxaDPZm7X27bDp7yoYU9V9gguEZjRtNGim/partyshare.busterlabs.xyz-1.2.7-linux.deb

hexagon6 commented 6 years ago

I guess, either we need to A) disable auto-update for linux builds or B) try to generate these files to get it working.

When testing your build, I get the following log output:

partyshare.busterlabs.xyz-1.2.7-linux.log

The following happens when I run the build:

  1. Partyshare opens a window
  2. Connecting to ipfs...
  3. Window disappears
  4. terminal logs stays / process still runs.
bhstahl commented 6 years ago

Ah, ok. I was able to generate the files with #54 so maybe we try doing a GitHub release and see if that fixes it by publishing the auto-update files?

bhstahl commented 6 years ago

I'm still worried about this though:

_connectToIPFS Error: non-zero exit code 255
  while running: /opt/Partyshare/resources/app.asar/node_modules/subcomandante/subcom 19399 /opt/Partyshare/resources/app.asar.unpacked/node_modules/go-ipfs-dep/go-ipfs/ipfs daemon

    at ChildProcess.<anonymous> (/opt/Partyshare/resources/app.asar/node_modules/subcomandante/fork.js:21:23)
    at emitTwo (events.js:130:20)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:921:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
bhstahl commented 6 years ago

Alright, here's to hoping this works!

https://github.com/BusterLabs/Partyshare/releases/tag/v1.3.0

bhstahl commented 6 years ago

Realizing the AppImage file wasn't included in 1.3.0, which I think auto-update uses, so I just committed 1.3.1 to include it.

hexagon6 commented 6 years ago

partyshare.busterlabs.xyz-1.3.1-linux.log

3 Errors: 1) [23:10:27.052] [error] [ipcMain] No window to send event on

2) [23:10:27.248] [error] Error: Error: ENOENT: no such file or directory, open '/opt/Partyshare/resources/app-update.yml'

3) [23:10:30.131] [error] [IPFSSync] _connectToIPFS Error: non-zero exit code 255 while running: /opt/Partyshare/resources/app.asar.unpacked/node_modules/go-ipfs-dep/go-ipfs/ipfs daemon

hexagon6 commented 6 years ago

1) Probably because I use i3. Will try on GNOME-environment 2) how does your app-update.yml look like? 3) don't know. my first build worked, maybe the dependency version (of ipfs-api) is a problem? https://github.com/hexagon6/Partyshare/blob/build-test2/package.json#L31

hexagon6 commented 6 years ago

The above errors where from the .deb package.

The AppImage package does not close the window, but is unable to connect to ipfs (probably only error 3).

Update: actually error 1 happens only when I move the mouse cursor out of the window. Update2: error 1 can be ignored, PEBKAC ;-)

In the AppImage package, update seems to be ok: [23:44:49.073] [info] Update for version 1.3.1 is not available (latest version: 1.3.1, downgrade is disallowed.. Makes sense to me that deb packages do not auto-update. Debian usually patches this away anyway.