search

ButchersBoy / Dragablz

Dragable and tearable tab control for WPF
http://dragablz.net
MIT License
2.17k stars 320 forks source link

dotCover reports WPF binding leak for bindings in TabablzControl template #236

Closed mgnslndh closed 4 years ago

mgnslndh commented 4 years ago

The Binding of DragablzItemsControl.MaxWidth to DesiredSize.Width in the TabablzControl template will cause dotCover to report a WPF binding leak.

https://github.com/ButchersBoy/Dragablz/blob/b7cf42899fe20d172dd81958360803836e48a99b/Dragablz/Themes/MaterialDesign.xaml#L622-L633

The issue seems to also be present in the default style.

This might not be a big issue but if we can come up with a nice solution I think it is good if remove even the small leaks so they do not cause too much noise when looking for the big ones.

However, I'm not sure what the the best solution would be. We could update the converter to also support Size values and pick either the Width or Height depending on the orientation of the converter. Thoughts and ideas?

mgnslndh commented 4 years ago

I'm closing this issue since it is a duplicate issue of #222. Sorry to have spammed :)