search

Buto / sails-oracledb-sp

A sails adapter specialized for invoking Oracle stored procedures
http://node-ora-sp.com
MIT License
2 stars 1 forks source link

Release connection on teardown #3

Open nethoncho opened 9 years ago

nethoncho commented 9 years ago

In the adapter teardown method, call release See https://github.com/oracle/node-oracledb/blob/master/doc/api.md#-424-release See https://github.com/ertrzyiks/sails-mongo/commit/30034f3d927920d9c5ac6d9747fe28581cbda1b1

Buto commented 9 years ago

Background: sails-oracledb-sp is not calling release during adapter teardown.
This occurs when "Sails lower" is issued.

Consequences: afterwards the adapter cannot be reloaded when "Sails reload" is issued.

nethoncho commented 9 years ago

This is waiting on balderdashy/waterline#697