ButterCMS / buttercms-csharp

.NET API client for ButterCMS (https://buttercms.com)
MIT License
40 stars 16 forks source link

Update target to .NET standard 2.1 #37

Closed vlnevyhosteny closed 1 year ago

vlnevyhosteny commented 1 year ago

This pull request includes updates to the library and test project:

vlnevyhosteny commented 1 year ago

Thanks for your patience as we decided how to proceed - we've decided to go with the major versioning change and making the old version obsolete, so as to avoid supporting two separate SDKs.

As such, can you also also bump the version in the readme.md and the .proj file: https://github.com/ButterCMS/buttercms-csharp/blob/master/ButterCMS/ButterCMS.csproj? and it looks like there are some deprecated tests that need to be upgraded: https://app.clickup.com/t/861n7ae7q - can we have these upgraded? Please let me know what you need from me to make that happen.

Thank you!

Version bumped in 63695f617e88cdf41f2b805e88c9b79c501f37c1.

ViolanteCodes commented 1 year ago

Thanks for your patience as we decided how to proceed - we've decided to go with the major versioning change and making the old version obsolete, so as to avoid supporting two separate SDKs. As such, can you also also bump the version in the readme.md and the .proj file: https://github.com/ButterCMS/buttercms-csharp/blob/master/ButterCMS/ButterCMS.csproj? and it looks like there are some deprecated tests that need to be upgraded: https://app.clickup.com/t/861n7ae7q - can we have these upgraded? Please let me know what you need from me to make that happen. Thank you!

Version bumped in 63695f6.

awesome, thank you - i'll wait to review until the new tests are done, so that they can go with the new version

vlnevyhosteny commented 1 year ago

PR with tests: https://github.com/ButterCMS/buttercms-csharp/pull/38