feat: Implement tests - Githubissues

ButterCMS / buttercms-python

Python API client for ButterCMS (https://buttercms.com)

MIT License

36 stars 11 forks source link

feat: Implement tests #11

Closed martinalbert closed 5 months ago

martinalbert commented 6 months ago

@Toreno96 thank you for the review, I understand your concerns and I don't like this approach as well.

I tried the responses package as well as vcr and I'm thinking if it wouldn't make more sense to use the VCR while we're at it. I tested it on one test and you can see the results in this commit: 62f5980a6dc5423e95f1e76b75e9f0a9a40b3c28

martinalbert commented 6 months ago

@Toreno96 Just to let you know why I tried also the VCR along the responses

They both solve the mentioned concern of superficial unit tests - intercepting underlying HTTP traffic instead of method calls,
It feels like similar amount of work would be needed to make the tests better,
VCR removes the need to create mocks manually and uses more realistic data