ButterCMS / dotnet-starter-buttercms

Drop-in proof-of-concept .NET app, fully integrated with your ButterCMS account
https://dotnet-starter-buttercms.herokuapp.com/
0 stars 2 forks source link

Add env variable PREVIEW to manage articles in preview mode #11

Closed prokopsimek closed 2 years ago

vlnevyhosteny commented 2 years ago

@prokopsimek I can't see Preview (or Testmode) option for .NET SDK. Am I missing something @ViolanteCodes ?

https://github.com/ButterCMS/buttercms-csharp/blob/master/ButterCMS/ButterCMSClient.cs#L52

ViolanteCodes commented 2 years ago

@jakelumetta

Can you weigh in on this - I also do not see preview listed in the SDK (https://github.com/ButterCMS/buttercms-csharp/blob/master/ButterCMS/ButterCMSClient.cs#L52), although we have it specified in a parameter in our API docs (https://buttercms.com/docs/api/?csharp#get-a-single-page) - do you want the preview function just left off of the starter app?

jakelumetta commented 2 years ago

Hmm this SDK may never have been enhanced to support that global config.

Can you update it to reflect how the other SDKs (ie JavaScript) support a preview Boolean config?

Alternatively, you could set a project level CONST for preview value and then pass that in as a parameter to all API calls.

On Mon, Apr 25, 2022 at 11:44 AM Maria Violante @.***> wrote:

@jakelumetta https://github.com/jakelumetta

Can you weigh in on this - I also do not see preview listed in the SDK ( https://github.com/ButterCMS/buttercms-csharp/blob/master/ButterCMS/ButterCMSClient.cs#L52), although we have it specified in a parameter in our API docs ( https://buttercms.com/docs/api/?csharp#get-a-single-page) - do you want the preview function just left off of the starter app?

— Reply to this email directly, view it on GitHub https://github.com/ButterCMS/dotnet-starter-buttercms/issues/11#issuecomment-1108741133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABHI2O7I2UQCSNWIFNZUWDVG24VJANCNFSM5TZ3V4UA . You are receiving this because you were mentioned.Message ID: @.***>

vlnevyhosteny commented 2 years ago

Created https://github.com/ButterCMS/buttercms-csharp/pull/30