search input - Githubissues

ButterCMS / gatsbyjs-starter-buttercms

Drop-in proof-of-concept GatsbyJS app, fully integrated with your ButterCMS account

https://gatsbyjs-starter-buttercms-vercel.vercel.app/

3 stars 8 forks source link

search input #6

Closed ViolanteCodes closed 2 years ago

ViolanteCodes commented 2 years ago

In the design repo the search input is called query https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/components/BlogWidget.js#L11

ViolanteCodes commented 2 years ago

@orlyohreally

Sorry - in both the specifications doc and checklist (I was running through both today), I have to use "q" for the query placeholder? It looks like @prokopsimek has replaced "q" with "query" - but if we're making this change across all projects, I need to update the readme + checklist, so let me know

orlyohreally commented 2 years ago

@ViolanteCodes mmm, I have checked django starter app and it's q as well, but its query in the nextjs starter app (that's why I mentioned this change). So probably need to update it in the nextjs project and go back with this change in this app. What do you think?

ViolanteCodes commented 2 years ago

@orlyohreally okay, sounds good to me.

@prokopsimek sorry, but can you change this back?

ViolanteCodes commented 2 years ago

merged: https://github.com/ButterCMS/gatsby-applifting/pull/42