Missing Avatar - Githubissues

ButterCMS / gatsbyjs-starter-buttercms

Drop-in proof-of-concept GatsbyJS app, fully integrated with your ButterCMS account

https://gatsbyjs-starter-buttercms-vercel.vercel.app/

3 stars 8 forks source link

Missing Avatar #9

Closed ViolanteCodes closed 2 years ago

ViolanteCodes commented 2 years ago

The author might not have an avatar. We should display placeholder avatar in that case https://github.com/ButterCMS/gatsby-applifting/blob/80901a171006d073436bb2cf59c0a06fe98f80d5/src/components/BlogPostsList.js#L24

prokopsimek commented 2 years ago

@ViolanteCodes There is no avatar in assets. Can you please send me the avatar you want to place there? Thanks

~It would be great to set the avatar on the API layer instead of letting developers make this workaround.~ //edit: It doesn't make sense. The developer wants to set his/her own avatar for own blog site.

ViolanteCodes commented 2 years ago

@orlyohreally this one's my fault, I told him to remove.

@prokopsimek I have put a placeholder in the front end assets:

https://github.com/ButterCMS/starter-project-front-end/blob/master/assets/images/placeholder.png

Let me know if that doesn't work, and sorry for the confusion.

prokopsimek commented 2 years ago

Fixed here: https://github.com/ButterCMS/gatsby-applifting/pull/35

ViolanteCodes commented 2 years ago

Merged