ButterCMS / java-starter-buttercms

Drop-in proof-of-concept Java + Spring app, fully integrated with your ButterCMS account
https://java-starter-buttercms.herokuapp.com/
0 stars 5 forks source link

trailing slashes missing on blog links from main view #4

Closed ViolanteCodes closed 2 years ago

ViolanteCodes commented 2 years ago

screenshot https://share.getcloudapp.com/p9u60Zrw

Can we please make sure all links include the trailing slashes? These link to blog post urls without trailing slashes. I realize that both url forms work to load the actual post (with and without trailing slash) but we've had issues in the past with other starter projects where lack of trailing slashes means the iframe preview does not work for apps hosted with heroku if trailing slashes are not present.

We would like to force trailing slashes throughout the project (e.g., if bare link is entered without trailing slash, returned URL has trailing slash, except for search pattern)

ViolanteCodes commented 2 years ago

@HonzaStefanik This is still not working; I think that maybe I didn't explain this well, my fault. I've shot a video with a more complete explanation, but in a nutshell:

video demo and explainer

A good working demo of this is in the laravel starter (http://laravel-starter-buttercms.herokuapp.com/)

ViolanteCodes commented 2 years ago

Bare URL routes are still not forcing trailing slashes, other than that, this is mostly fixed. Is it possible to force the trailing slashes, or would that require drastic intervention @HonzaStefanik? Just let me know

HonzaStefanik commented 2 years ago

It should be hopefully fixed now :)

ViolanteCodes commented 2 years ago

Looks to have been fixed by PR #9, TY