search

ButterFlight / butterflight

GNU General Public License v3.0
106 stars 26 forks source link

pid setpoint calculation is wrong #73

Closed robert-b closed 6 years ago

robert-b commented 6 years ago

dtermSetpointWeight = pidProfile->dtermSetpointWeight / 127.0f;

when using full, 100 % , dterm weighting weighting it is in the configurator displayed as 1.27 you should team up getting the calculus right ...

kidBrazil commented 6 years ago

@robert-b I am a bit confused here, you are saying that when you set Dterm setpoint weight to max value in configurator it gets displayed as 1.27? Where does that get displayed? UI?

robert-b commented 6 years ago

it is the slider in the pid tab. setpoint weighting would be the english term.

orneryd commented 6 years ago

I think it's a display "feature" just like the pids and other values which are displayed differently and then scaled when used.