search

ButterFlight / butterflight

GNU General Public License v3.0
106 stars 26 forks source link

Please create a cli command to turn on the disarm switch that was removed #80

Closed GRaNTMaTT closed 6 years ago

GRaNTMaTT commented 6 years ago

BF 3.3.0 disabled the ability to disarm in the air, which in my opinion, is dangerous for all of us that have been landing using this setting since CleanFlight. Why can't there be a cli command that turns this back on?

kidBrazil commented 6 years ago

It goes against RC convention to have the arm switch not be an actual kill switch. I know you guys have been doing this for years but I am sorry to say it is an unsafe practice.

We are not opposed to including it as a CLI option, provided the default of that option is for it to be OFF. Meaning, when the arm switch is killed, the quad drops. Because that is expected behavior and safer behavior.

That said, we have already discussed this point, none of the Butter devs have time or interest in this feature at this moment. You are more than welcome to submit a PR with a solution and we will review it and discuss it fairly.

Cheers

GRaNTMaTT commented 6 years ago

You will see a lot more bitching about this feature being removed as us old timers begin to upgrade to BF 3.3x and BuF 3.x.x. Count on it ;)

kidBrazil commented 6 years ago

@WiKDMoNKY That is fine - maybe one of them has some coding chops and they can just submit a PR for us to review =D

GRaNTMaTT commented 6 years ago

I doubt it, but there are a couple of us working on a modified BuF firmware that will put the setting back in. We may possibly make our own fork. Sometimes ya gotta do what you gotta do when Big Brother tries to tell seasoned pilots what is safe for us ;)

kidBrazil commented 6 years ago

@WiKDMoNKY thats fine my friend, that is the beauty of open source. I am sorry we dont agree on this issue.. but I have to think of big picture here and not just your group. I have no way of knowing exactly who is using this software for what and I would HATE to know that something I worked on hurt someone.

I have consulted with many RC experts on this matter and they all agree that for Heli / Plane / Quad - disarm switch SHOULD be a full killswitch. Having it depend on another factor makes it "Landing switch" and not an arm/disarm

therealjonnyd commented 6 years ago

I keep seeing the same people (person) bringing this up. I don't think it's the widespread issue that it's being made out to be. It's inherently unsafe, therefore it was removed. In all fairness, it shouldn't have EVER been an option. By all means, set it up in your radio at your own risk if you'd like but this reminds me of my grandfather cutting the seatbelts out of his Buick because he didn't believe in them.

I highly suggest you relearn how to land. It's very simple to land with airmode off and disarm completely upon touching down.

theSkonk commented 6 years ago

or just do what most racers do... get low, slow and kill switch the beast!

iAMsinister commented 6 years ago

how does that make sense? "I doubt it, but there are a couple of us working on a modified BuF firmware that will put the setting back in. We may possibly make our own fork."

why not just submit a PR like Loose asked? landing is honestly not that hard even with airmode on.. ill gladly post a video demonstrating me landing on a 30m high dive with airmode on disarming and taking off again, on a windy af day mind you. i kno the whole saying "old dog new tricks.." but thing is y'all where practicing an unsafe landing procedure from the get go..

GRaNTMaTT commented 6 years ago

I/we are over trying to get this changed and are dealing with learning to land "the safe way" that big brother deems as necessary to be safe.

frakkan commented 6 years ago

Did I miss something? Where was the disarm switch removed? I am flying 3.5fw and have an arm switch on an aux channel. Anytime i can disarm my quad.... Sorry for asking, but just want to understand the debate.

On Thu, 5 Apr 2018, 16:11 iAMsinister, notifications@github.com wrote:

how does that make sense? "I doubt it, but there are a couple of us working on a modified BuF firmware that will put the setting back in. We may possibly make our own fork."

why not just submit a PR like Loose asked? landing is honestly not that hard even with airmode on.. ill gladly post a video demonstrating me landing on a 30m high dive with airmode on disarming and taking off again, on a windy af day mind you. i kno the whole saying "old dog new tricks.." but thing is y'all where practicing an unsafe landing procedure from the get go..

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ButterFlight/butterflight/issues/80#issuecomment-378950013, or mute the thread https://github.com/notifications/unsubscribe-auth/AOLCyXXiRSsNIA1urXmVJFpaaLi62QDhks5tliYcgaJpZM4S9wUo .

theSkonk commented 6 years ago

@frakkan in older beta flight versions you could disarm while flying and the 'disarm' would not come into effect until you actually shut the throttle..

kidBrazil commented 6 years ago

@frakkan @theSkonk I would consider this issue well put to bed by now. Neither beta nor butter have any desire to include this option - the people asking for the option don't seem willing to create the solution.

theSkonk commented 6 years ago

I don't want it.. just explaining to @frakkan what the request is for @kidbrazil..