Open inolen opened 2 years ago
Hey there.
Over time there are more entity types added - and yes it's in flattened_serializer.inline
where you specify how these are decoded - you got it spot on. If you see the git history I've had the same maintenance to do over time.
At some point in the past there's been something which has gone wonky in the decoding, here's decoding status grouped by patch (for pro games):
patch_name | num_good | num_bad
------------+------+------
6.84 | 169 | 13
6.85 | 1560 | 30
6.86 | 2349 | 54
6.87 | 1427 | 18
6.88 | 3381 | 72
7.00 | 132 | 31
7.01 | 641 | 10
7.02 | 414 | 38
7.03 | 147 | 1
7.04 | 235 | 6
7.05 | 750 | 12
7.06 | 2032 | 74
7.07 | 1602 | 20
7.08 | 445 | 5
7.09 | 181 | 2
7.10 | 193 | 2
7.11 | 416 | 6
7.12 | 213 | 2
7.13 | 280 | 4
7.14 | 121 | 1
7.15 | 175 | 1
7.16 | 97 | 6
7.17 | 246 | 1
7.18 | 129 | 1
7.19 | 1102 | 65
7.20 | 674 | 9
7.21 | 1924 | 25
7.22 | 1812 | 21
7.23 | 463 | 8
7.24 | 563 | 40
7.25 | 569 | 46
7.26 | 1393 | 191
7.27 | 2100 | 1199
7.28 | 0 | 1703
7.29 | 0 | 2015
7.30 | 0 | 1376
You can see that in 7.24 things started going quite pear-shaped.
Because I only use butterfly for audio-parsing (and not general replay parsing), it's not been a super high priority for me to fix it exactly, however I did discuss this with @spheenik a while ago and we said we'd look into it when we got time (he's currently in the process of moving).
It's certainly a bug I want to fix - firstly so I can reparse the broken audio, but also because I'd like to recompile the Javascript lib. I'm just not sure when I will have time to look into it right now, maybe spheenik has some time over Christmas break and we can fix it up. Definitely would be interested if you come across any ideas / solutions.
@Noxville thanks for the heads up! Is that data set you're testing against available for download anywhere?
It's just the pro matches on datdota.com - if you're having trouble getting some ping me on Discord (on discord.gg/datdota).
@inolen Had any luck with parsing? I'm facing the same issue as well.
Hi,
I was trying to use the 01-basic tool for the first time on a recent demo, and on parsing I get:
I naively copied and pasted a bunch of seemingly similar fields thinking they may have just been renamed in the underlying code:
until I hit:
Have I done something wrong here, or are these just new changes to the replay format that aren't yet supported?
Thanks!