fully upgrade to TypeScript 4.x

Buuntu / fastapi-react

🚀 Cookiecutter Template for FastAPI + React Projects. Using PostgreSQL, SQLAlchemy, and Docker

MIT License

2.19k stars 349 forks source link

fully upgrade to TypeScript 4.x #178

Open cardoe opened 2 years ago

cardoe commented 2 years ago

The project pulled in TypeScript 4.x but used other dependencies that were not compatible with TypeScript 4.x which resulted in failures out of the box that provided no context as to what was going wrong.

cardoe commented 2 years ago

includes the fix for #171 as well

Buuntu commented 2 years ago

Can we take out the extra changes and dependencies and just stick to the Typescript upgrade? I will approve with just that, I'd rather not add extra dependencies to the base project though.

cardoe commented 2 years ago

Sure. The frontend won't compile without them.

luq7 commented 2 years ago

@cardoe Is this PR supposed to fix this error?