Implement Localisation and Improve Blacklist Performance

Buuz135 / DarkModeEverywhere

MIT License

7 stars 9 forks source link

Closed Lordfirespeed closed 1 year ago

Lordfirespeed commented 1 year ago

Additionally:

Remove redundant (previously disabled) config options
utilise early returns to make button press logic more understandable
Improve some variable names by adding context
Store ResourceLocations in ShaderValues instead of the strings referencing the locations
Improve blacklist performance + readability by
- Using a HashMap to store blacklist elements (instant lookups!)
- storing whether elements are blacklisted (as well as not) so that this doesn't have to be re-computed

Lordfirespeed commented 1 year ago

Oh, I haven't bumped version. I'll leave that to you, if that's okay?

Buuz135 commented 1 year ago

Yep

Lordfirespeed commented 1 year ago

I think this pull request is complete. If you have any other comments let me know and we can resolve asap :)

Lordfirespeed commented 1 year ago

Once this PR is merged, I have a 1.19.4 implementation mostly complete (if you're interested)