Buuz135 / DarkModeEverywhere

MIT License
7 stars 9 forks source link

Elements Missing from Blacklist #32

Open Lordfirespeed opened 1 year ago

Lordfirespeed commented 1 year ago

Please comment here if you find elements you think should be included in the default method blacklist! I'll try to keep the table as up-to-date as possible.

Element description 1.18.2 1.19.4 1.20.1 Related class/method name Obfuscated name
Server icons in multiplayer list #31 #34 #41 OnlineServerEntry:drawIcon OnlineServerEntry:m_99889_
World icons in singleplayer list #39 #40 #41 WorldSelectionList$WorldListEntry:render WorldSelectionList$WorldListEntry:m_6311_
Custom packmenu backgrounds #39 #40 #41 shadows.packmenu.ExtendedMenuScreen N/A
AppleSkin hunger overlay #31 #40 #41 squeek.appleskin.client.HUDOverlayHandler N/A
Configured config background #39 #40 #41 configured.client.screen.ListMenuScreen N/A
Main title screen panorama 1.19+ N/A #40 #41 CubeMap:render CubeMap:m_108849_
BlakeIsMyWaifu commented 1 year ago

Minecraft Version: 1.18.2 DarkModeEverywhere Version: 1.1.3

The animal dictionary book from Alex Mobs is missing from the blacklist. I've tried to add the methods to the blacklist but they don't seem to work.

[13Sep2023 18:41:22.394] [Thread-46/INFO] [com.buuz135.darkmodeeverywhere.RenderedClassesTracker/]: com.github.alexthe666.citadel.client.gui.EntityLinkButton:m_6303_
[13Sep2023 18:41:22.394] [Thread-46/INFO] [com.buuz135.darkmodeeverywhere.RenderedClassesTracker/]: com.github.alexthe666.citadel.client.gui.BookPageButton:drawNextArrow
[13Sep2023 18:41:22.394] [Thread-46/INFO] [com.buuz135.darkmodeeverywhere.RenderedClassesTracker/]: com.github.alexthe666.citadel.client.gui.BookPageButton:m_6303_
[13Sep2023 18:41:22.394] [Thread-46/INFO] [com.buuz135.darkmodeeverywhere.RenderedClassesTracker/]: com.github.alexthe666.citadel.client.gui.EntityLinkButton:drawBtn
[13Sep2023 18:41:22.394] [Thread-46/INFO] [com.buuz135.darkmodeeverywhere.RenderedClassesTracker/]: com.github.alexthe666.citadel.client.gui.EntityLinkButton$EnttyRenderWindow:renderEntityWindow

The issue is also mentioned here https://github.com/FTBTeam/FTB-Modpack-Issues/issues/2689