Buuz135 / FunctionalStorage

FunctionalStorage
MIT License
30 stars 33 forks source link

[1.18.2] Crash interaction with Chipped mod while making Framed Drawer #155

Open Raidobw2 opened 1 year ago

Raidobw2 commented 1 year ago

When crafting a framed drawer using specific Chipped blocks on Forge 40.2.0, the game will crash!

I seem to be having the same issue #151 was having, this was originally reported to me at https://github.com/FTBTeam/FTB-Modpack-Issues/issues/2452. In the few tests I did, chipped:light_blue_concrete_19 was one of the blocks the craft crashed with. Chipped uses CTM (connected textures mod) for some of its blocks, which includes that 19th variant of the block.

See the following gif, where the game froze and then crashed:

Game crash while crafting framed drawer ![concrete](https://user-images.githubusercontent.com/17010632/214756861-67af94ad-48dd-449b-9737-34ec33de4e2d.gif)

Functional Storage Version: functionalstorage-1.18.2-1.1.3.jar (latest as of now)

Titanium Version: titanium-1.18.2-3.5.8-40.jar (latest as of now)

Chipped Version: chipped-forge-1.18.2-2.0.1.jar (latest as of now)

CTM Version: CTM-1.18.2-1.1.5+5.jar (latest as of now)

Forge: 40.2.0

Crashlog If Applicable (Upload to pastebin/gist): Paste: https://paste.feed-the-beast.com/view/2c45e4bf File: crash-2023-01-25_22.58.39-client.txt

Thanks for checking this out in advance!

osirisgothra commented 1 year ago

(Submitted here so the author won't have to dupe-flag/move it) This also happens in Stoneblock 3, the crash report attached was triggered by accidentally using a Cobblestone Wall (Vanilla) as a texture item--in was the first slot IIRC, before the second texture was put in the second, with the framed untextured 4x4 drawer in the third slot. Though it was a tinker's construct crafting station, it also did this in other crafting grids including the vanilla type.


Specifications Summary:

Modpack: Stoneblock 3 Modpack Version: 1.4.3-0 Modpack Loader: Forge Forge Version: 40.1.86 Minecraft Version: 1.18.2 Java Version: 17.0.6 (build 9-LTS-190, 64-bit, date 1/17/2023, mixed mode, sharing) OS/Version Windows/10.0.19044.2604 CPU Architecture, Memory: Intel i7 (64-bit), 16GB Video Adapter: NVidia Geforce GT610/SSE2/PCIe Disk: SSD Kingfast 238.47GiB (256GB), At least 11GB Free+Swap

Other Secondary Specs That Might Be Useful:

Windows Swap: System Managed, ~48GB Java-Allocated RAM: 8GB Resource Packs in use? NO (only ones default with SB3) Shader Packs in use? NO (none) Custom Video Mod in use? YES (Rubdium 0.5.4, Occulus 1.4.3a) Any other custom mods in use? NO Custom Configs in use? NO Custom Scripts in use? NO World type: Default, Single-player (mineshaft intersection preset chosen via SB3's starting point) Modpack Installed for How Long: 13 days, 2 hours, 53 minutes (since 2/27/2023) Game days played (Time-played stat): 6.10d Approx Level.dat size: 316KiB Approx Player data size: 109KiB Average Allocated Memory Size While Playing: 4347MiB In force loaded chunk? YES In claimed chunk/claims enabled? YES/YES Playing resolution: Windowed, 848x480


The first part of sb3-crash-report.txt showing topmost object in the log:


[13:06:17] [Render thread/FATAL]: Preparing crash report with UUID 4b967a33-5fc8-40fe-941c-52cf283e684c
---- Minecraft Crash Report ----
// You should try our sister game, Minceraft!

Time: 3/12/23, 1:06 PM
Description: Rendering item

java.lang.NullPointerException: Cannot invoke "net.minecraft.core.Direction.m_122421_()" because "side" is null
    at com.buuz135.functionalstorage.client.loader.FramedModel$Baked.getMinMaxPosition(FramedModel.java:228) ~[functionalstorage-1.18.2-1.0.7.jar%23146!/:1.18.2-1.0.7] {re:classloading,pl:epic_rei_lmao:B}
    at com.buuz135.functionalstorage.client.loader.FramedModel$Baked.getSpriteData(FramedModel.java:203) ~[functionalstorage-1.18.2-1.0.7.jar%23146!/:1.18.2-1.0.7] {re:classloading,pl:epic_rei_lmao:B}
    at com.buuz135.functionalstorage.client.loader.FramedModel$Baked.getQuadsUsingShape(FramedModel.java:183) ~[functionalstorage-1.18.2-1.0.7.jar%23146!/:1.18.2-1.0.7] {re:classloading,pl:epic_rei_lmao:B}
    at com.buuz135.functionalstorage.client.loader.FramedModel$ItemModel.getQuads(FramedModel.java:582) ~[functionalstorage-1.18.2-1.0.7.jar%23146!/:1.18.2-1.0.7] {re:classloading,pl:epic_rei_lmao:B}
    at net.minecraftforge.client.model.data.IDynamicBakedModel.m_6840_(IDynamicBakedModel.java:27) ~[forge-1.18.2-40.1.86-universal.jar%23283!/:?] {re:classloading,pl:epic_rei_lmao:B,re:mixin}
    at net.minecraft.client.renderer.entity.ItemRenderer.m_115189_(ItemRenderer.java:554) ~[client-1.18.2-20220404.173914-srg.jar%23278!/:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:epic_rei_lmao:B,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}

Hope that helps out in the quest for some sort of workaround/patch/update (that and the render-inside thing, cant seem to update forge on sb3 so i have no idea bout that one).