Buuz135 / SushiGoCrafting

MIT License
8 stars 13 forks source link

Mob spawning is too generous #4

Closed abint closed 3 years ago

abint commented 3 years ago

Minecraft version: 1.16.5

Forge version: 36.1.9

Sushi Go Crafting version: 0.1.1 (I know its older. Entity source code hasn't been edited since then, though)

Issue description: All tuna & shrimp do not validate spawning beyond ocean biome. They can spawn in walls, in the sky, in caves, etc relative to where the player is. This can cause an excessive amount of item entities (400+) to exist while in ocean biomes.

What is expected to happen: Tuna & shrimp be limited to spawning ONLY in water like how vanilla fish and squids are limited to spawn.

Reproduction steps: Be in a world with few to no Sushi Go mobs, Raise your height to far above sea level or below sea level, Enter an ocean biome type, Observe mobs spawning midair or F3 entity count climbing due to item drops

ZephyrWindSpirit commented 3 years ago

I take your 400+ entity spawns on 0.1.1, and raise it to 0.1.3 with 800+ spawns good sir, on the same forge and minecraft version. https://cdn.discordapp.com/attachments/106875827769065472/844202462222090240/unknown.png https://media.discordapp.net/attachments/106875827769065472/844202395227783228/unknown.png https://media.discordapp.net/attachments/106875827769065472/844160387897098257/unknown.png https://media.discordapp.net/attachments/106875827769065472/843890560162988032/unknown.png Cave pictures are about y 15