BuxOrg / bux

Bitcoin UTXO & xPub Management Engine
https://getbux.io
Apache License 2.0
36 stars 6 forks source link

feat(BUX-525): remove unused graphql methods #553

Closed pawellewandowski98 closed 9 months ago

pawellewandowski98 commented 9 months ago

Pull Request Checklist

Description

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3ed84e6) 53.89% compared to head (52b74ed) 53.85%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/BuxOrg/bux/pull/553/graphs/tree.svg?width=650&height=150&src=pr&token=gh8XH5lven&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg)](https://app.codecov.io/gh/BuxOrg/bux/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg) ```diff @@ Coverage Diff @@ ## master #553 +/- ## ========================================== - Coverage 53.89% 53.85% -0.04% ========================================== Files 110 110 Lines 10853 10831 -22 ========================================== - Hits 5849 5833 -16 + Misses 4533 4529 -4 + Partials 471 469 -2 ``` | [Flag](https://app.codecov.io/gh/BuxOrg/bux/pull/553/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg) | Coverage Ξ” | | |---|---|---| | [unittests](https://app.codecov.io/gh/BuxOrg/bux/pull/553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg) | `53.85% <ΓΈ> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/BuxOrg/bux/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg) | Coverage Ξ” | | |---|---|---| | [action\_destination.go](https://app.codecov.io/gh/BuxOrg/bux/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg#diff-YWN0aW9uX2Rlc3RpbmF0aW9uLmdv) | `52.65% <ΓΈ> (ΓΈ)` | | | [model\_ids.go](https://app.codecov.io/gh/BuxOrg/bux/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg#diff-bW9kZWxfaWRzLmdv) | `76.00% <ΓΈ> (+0.32%)` | :arrow_up: | | [model\_metadata.go](https://app.codecov.io/gh/BuxOrg/bux/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg#diff-bW9kZWxfbWV0YWRhdGEuZ28=) | `88.99% <ΓΈ> (+1.59%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/BuxOrg/bux/pull/553?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/BuxOrg/bux/pull/553?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg). Last update [3ed84e6...52b74ed](https://app.codecov.io/gh/BuxOrg/bux/pull/553?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg).
chris-4chain commented 9 months ago

One additional graphql string I found in the project in a comment: // this will be set when calling NewDestination from http / graphql, but not for instance paymail

It's in action_destination.go line 81.