BuyBitcoinWorldwide / bitcointreasuries

Submit updates for Bitcoin Treasuries page
23 stars 9 forks source link

Summary table "Last Updated" field not updated when "# of BTC" field is updated #51

Closed superclarkk closed 4 months ago

superclarkk commented 4 months ago

I just noticed, on the 1st March at about 16:00 UTC, the "# of BTC" field changed without the "Last Updated" field changing. It still says "February 29, 2024".

Screenshot from 2024-03-01 16-00-04

JTuwiner commented 4 months ago

working on fix now. thanks.

superclarkk commented 4 months ago

Ignore my comment from earlier today. My mistake. Deleted now.

JTuwiner commented 4 months ago

no worries, always open to feedback. this was because we added wrapped BTC and since it was new, forgot to to change the date.

superclarkk commented 4 months ago

Thanks - appreciated. Unfortunately, the total was updated this morning at around 5am UTC, but the date remains the same. Screenshot from 2024-03-03 11-35-44

JTuwiner commented 4 months ago

ok will keep an eye on it

superclarkk commented 3 months ago

Could this be a timezone issue? I guess I assumed the update date is in UTC. It updated at around 2am UTC on 10th March, while the Last Updated date is the 9th.

JTuwiner commented 3 months ago

i changed it last night around 8PM EST on March 9th.

superclarkk commented 3 months ago

But is the date in EST or UTC? If you have a global market, it should be in UTC.

The total BTC just updated, and the date is incorrect again Screenshot from 2024-03-11 13-45-33 .

JTuwiner commented 3 months ago

Just remember, we're doing this manually. We try our best, but mistakes happen.

I updated MicroStrategy just now, but forgot to change the date. It has been EST until now, but will look into changing it to UTC.

superclarkk commented 3 months ago

I didn't realise it was manual. Ouch - I assumed you were scraping everything.

The date is wrong after the latest update too, I'm afraid. The UTC time is 13:30, which is 9:30 in EST, so it's not the timezone alone causing it.

So, do you need to manually update the date every time you update a value?

image

JTuwiner commented 3 months ago
Screenshot 2024-03-13 at 9 44 06 AM

this was updated last night, but i only pushed the change this morning