search

BuzzCutNorman / tap-mssql

Singer Tap for MS SQL built with Meltano Singer SDK.
MIT License
2 stars 9 forks source link

fix engine creation not saving port settings #12

Closed mrhorvath closed 1 year ago

mrhorvath commented 1 year ago

URL.set returns an immutable copy of the config mapping

BuzzCutNorman commented 1 year ago

@mrhorvath thanks for the PR. If you would please give me an example of what you fixing. I believe I know what this is for but just wanted to make sure we are on the same page.

BuzzCutNorman commented 1 year ago

@mrhorvath Never mind I see where what you are talking about. Thanks, for the comments and PR.

fix engine creation not saving port settings.  URL.set returns an immutable copy of the config mapping