BuzzCutNorman / tap-mssql

Singer Tap for MS SQL built with Meltano Singer SDK.
MIT License
2 stars 9 forks source link

bug: Batch extract runs into TypeError: Object of type is not JSON serializable #23

Closed BuzzCutNorman closed 1 year ago

BuzzCutNorman commented 1 year ago

Here are all the types that I currently know are running into this issue when the tap is generating batch messages.

I think the best path is to overload the default JSON encoder used in the json.dump portion of get_batches. I found these links that have been helpful.

BuzzCutNorman commented 1 year ago

I found that time is not a type that to_jsonschema_type() handles. I will add support for time in the PR assocaited with this issue.

BuzzCutNorman commented 1 year ago

I found some error with decimal columns. I will be placing a fix for this in the PR associated with this issue.