search

BuzzCutNorman / tap-mssql

Singer Tap for MS SQL built with Meltano Singer SDK.
MIT License
2 stars 9 forks source link

Fix: date interval #45

Open davert0 opened 1 year ago

davert0 commented 1 year ago

Hey @BuzzCutNorman! Thanks for fixing the incremental replication! I found another bug when trying to download a table with a Date replication field. I have a pretty large view in my database, and if I don't specify an upper bound on the interval, the query tries to read all the data, so I added an upper interval in the future time

BuzzCutNorman commented 1 year ago

@davert0 Thanks for the kind words and the PR. I created a test scenario and got an error as you described. I created an Issue for the error I got #46. Please take a look and let me know if it matches what you experienced.

I regards to your upper bound feature request. Please let me know if this Singer-SDK issue describes what you are needing for your large view: https://github.com/meltano/sdk/issues/922