search

BuzzCutNorman / tap-mssql

Singer Tap for MS SQL built with Meltano Singer SDK.
MIT License
2 stars 9 forks source link

Pendulum dependency missing #79

Closed anna-nylander closed 3 months ago

anna-nylander commented 3 months ago

I'm using this tap in a meltano project and since the latest release the tap crashes due to missing import. The "Pendulum" python package is removed in meltano SDK 0.39.1, but still used by this tap and not installed explicitly. Maybe we can add pendulum to the poetry dependencies or use another package for datetimes? Thanks :)

BuzzCutNorman commented 3 months ago

Thank you for pointing this out and the PR to resolve the issue. If you would please give this PR a try and see if it resolves your issue.

https://github.com/BuzzCutNorman/tap-mssql.git@encoding-via-msgspec

BuzzCutNorman commented 3 months ago

Thank You! Anna