search

Buzzinoffbond / phpliteadmin

Automatically exported from code.google.com/p/phpliteadmin
0 stars 0 forks source link

2 typos: "is_readeable" (unknown function) and index j vs. i in dev. 1.9.4 #180

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
double misspell

see patch

Original issue reported on code.google.com by ykoro...@gmail.com on 26 Feb 2013 at 9:39

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks. "is_writeable" is okay, as there is an alias:
http://de.php.net/manual/en/function.is-writeable.php

is_readeable obviously is a typo. Thanks, I'll fix it (both).

Original comment by crazy4ch...@gmail.com on 26 Feb 2013 at 10:01

GoogleCodeExporter commented 9 years ago 
This bug was introduced in Rev r336 while Fixing issue #175.

Original comment by crazy4ch...@gmail.com on 26 Feb 2013 at 10:07

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r342.

Original comment by crazy4ch...@gmail.com on 26 Feb 2013 at 10:11

GoogleCodeExporter commented 9 years ago 
you're welcome. great project

I've changed is_writeable only to match is_readable. Under second typo I meant 
index 'j', you probably meant 'i'. At least after change it works for me :)

Original comment by ykoro...@gmail.com on 26 Feb 2013 at 10:25

GoogleCodeExporter commented 9 years ago 
Ah, thanks for making me aware of this.
i only looked at your patch in the google website and did not spot the i-vs-j 
mistake (because the small change it is hard to see without graphical 
highlighting). Should have applied your patch to spot it.

I just fixed the index-problem.

Original comment by crazy4ch...@gmail.com on 26 Feb 2013 at 10:33

GoogleCodeExporter commented 9 years ago 
We should clearly reduce the copy&paste amount in phpLiteAdmin. Both typos are 
kind of copy-and-paste related: is_readeable was a typo I copied, spotted the 
mistake, but corrected it only at one place. The index is i at one place, j at 
the other, which I did not see when copying.

To avoid this kind of mistakes, we should go on improving the structure so less 
copy&paste is necessary and the code becomes more easy to maintain.

Original comment by crazy4ch...@gmail.com on 26 Feb 2013 at 10:40

GoogleCodeExporter commented 9 years ago 
yep. that's good, 'cause I've created bad patch (it was within 1.9.4 directory, 
wrong headers)

hehe

Original comment by ykoro...@gmail.com on 26 Feb 2013 at 10:48