search

Buzzinoffbond / phpliteadmin

Automatically exported from code.google.com/p/phpliteadmin
0 stars 0 forks source link

Make Date / Time format language-dependant #189

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently, the format in which date and time is outputted is specified within 
the code. It would be better to specify it within language files, so each 
language could choose the date-format that is most suitable for the speakers of 
this language.

Moreover, there seem to be 2 different formats used at the moment: One for date 
& time of the last change of a db, and one for the date & time a sql dump was 
generated.
I don't see a good reason why to use different formats there.

Original issue reported on code.google.com by crazy4ch...@gmail.com on 7 Mar 2013 at 2:56

GoogleCodeExporter commented 9 years ago 
(this was first mentioned as a comment in issue #186.)

Original comment by crazy4ch...@gmail.com on 7 Mar 2013 at 2:57

GoogleCodeExporter commented 9 years ago

Original comment by crazy4ch...@gmail.com on 7 Mar 2013 at 3:02

GoogleCodeExporter commented 9 years ago 
What about using an ISO or RFC format, so dates are easy to parse? (i.e., 
date('c') or date('r') in php)

Original comment by dreadnaut on 7 Mar 2013 at 6:38

GoogleCodeExporter commented 9 years ago 
Hmm. Why should you want to parse these dates?
Maybe the date in the sql-export. But the date of the last modification of the 
db is something we display for the user. No reason to parse the html to find 
this out, you could easier do filemtime() yourself. So this date should clearly 
be displayed in a way that is most readable for the user (which ISO 8601 isn't 
in my opinion and RFC 2822 might be well readable for English speaking users, 
but as a German user this is a rather uncommon format and I would prefer 
date("d.m.Y H:i:s (T)"). And other languages would use other formats.

For the sql-dump, you could argue a well parsable date might be okay. But I 
think nobody parses the comments of the sql-dump. Especially if the date is 
included in the filename. So I think a format that is most readable for the 
user is best here as well.

Original comment by crazy4ch...@gmail.com on 7 Mar 2013 at 9:20

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r351.

Original comment by crazy4ch...@gmail.com on 9 Mar 2013 at 1:59

GoogleCodeExporter commented 9 years ago

Original comment by crazy4ch...@gmail.com on 9 Mar 2013 at 2:00