Buzzpy / Dev-Encyclopedia

An encyclopedia for everything, Programming.
https://devpedia.dev
Other
255 stars 56 forks source link

Image view on mobile (Android) #12

Closed sasakiRoo closed 4 weeks ago

sasakiRoo commented 4 weeks ago

The site is good! But there's a problem in showing image. The image doesn't show fully. For example, you searched "Serverless Computing" and click it, there's an image-illustration about what "serverless computing", but doesn't show fully, or being cropped.

Buzzpy commented 4 weeks ago

Thanks for mentioning it!

@pikhosh could this be because of PR #10 or PR #11 ? The images were not responsive at the beginning (it didn't resize accordingly) but this one is new.

I think it's not scrollable too.

Buzzpy commented 4 weeks ago

Thanks for mentioning it!

@pikhosh could this be because of PR #10 or PR #11 ? The images were not responsive at the beginning (it didn't resize accordingly) but this one is new.

I think it's not scrollable too.

It's because of PR #11 , I reverted the merge, and the scrolling issue is solved.

RayMathew commented 4 weeks ago

Do you still want to fix the issue of the full image not being visible?

Suggestions:

  1. Make the modal bigger, and use a cross button to exit, rather than tapping somewhere in the background. Not a complete solution but still useful I think, since you don't want to have to scroll so much on an already small screen.
  2. Apply CSS so that the image always fits within the width of the screen. Problem with this is that some images can become too small to read.
  3. Implement point 2, and also add the feature of zooming in when you tap on the image.

I'll be happy to help implement the above or any other suggestions.

pikhosh commented 4 weeks ago
  1. Apply CSS so that the image always fits within the width of the screen. Problem with this is that some images can become too small to read.

I think the common CSS style for images is good enough; it's readable and if someone can't read, the browser zoom feature and opening the image in a new tab is the way to go usually.

Buzzpy commented 4 weeks ago

Solved with the PR #23 A huge thank you to @pikhosh !

image