search

ByMykel / CSGO-API

An unofficial JSON API for Counter-Strike 2 in multiples languages. List of skins, cases, stickers, collections, collectibles, agents, graffiti, keys, patches and music kits.
https://bymykel.github.io/CSGO-API/
MIT License
255 stars 29 forks source link

StatTrak™ Music Kits and weapons wears. #116

Open yesworId opened 2 months ago

yesworId commented 2 months ago

Would be great if music kits, which are contained in StatTrak™ Music Kit Box, would have StatTrak™ prefix in their names too. Also, would be useful if every weapon skin would have it's wear ranges in crate content dictionary (min_float and max_float values) and not repeatedly written in every weapon skin with a different wear dictionaries (like weapon_id_0 - Factory New, weapon_id_1 - Minimal Wear....).

yesworId commented 2 months ago

Another issue I've encounter, incorrect "Mil-Spec Grade" weapon wear in library's code. This wear should be "Mil-Spec" These are correct list of all weapon wears, according to Valve's names:

WEAPON_RARITIES = [
    'Contraband',
    'Extraordinary',
    'Covert',
    'Classified',
    'Restricted',
    'Mil-Spec',
    'Mil-Spec Grade',  # IS INCORRECT NAME (BUT USED IN CSGO-API)
    'Industrial Grade',
    'Consumer Grade'
]
ByMykel commented 2 months ago

Another issue I've encounter, incorrect "Mil-Spec Grade" weapon wear in library's code. This wear should be "Mil-Spec" These are correct list of all weapon wears, according to Valve's names:

WEAPON_RARITIES = [
    'Contraband',
    'Extraordinary',
    'Covert',
    'Classified',
    'Restricted',
    'Mil-Spec',
    'Mil-Spec Grade',  # IS INCORRECT NAME (BUT USED IN CSGO-API)
    'Industrial Grade',
    'Consumer Grade'
]

hmm if I am not mistaken I got the translation directly from csgo_english.json

image

EDIT: also thanks for the issue, lately I don't have a lot of free time to spend on this project, so it might be a long wait.

yesworId commented 2 months ago

Sorry, I think I'm wrong. I double checked it in the steam community market filters and version with "Grade" is right.